Weird glitch (possibly?)

[BladeGamez]

So for some weird reason, my code was working a while ago and quit. So I toggled with it and managed to get something out of it. This time, however, instead of changing it to the correct sprite like it was supposed to, it flickered in between two other unrelated sprites. Now I toggled it again and it stopped working completely. What did I do wrong?

Code below
if keyboard_check (vk_shift) and keyboard_check (vk_right)
then
{
sprite_index = spritera;
}
else
{
sprite_index = sprite1;
}

if keyboard_check (vk_shift) and keyboard_check ("D")
then
{
sprite_index = spritera;
}
else
{
sprite_index = sprite1;
}

 

[obscene]

Your second block overwrites your first. If you press right and , it turns to spritera, but then immediately gets set back because you arent holding D.

Combine this all into one neat block...

if keyboard_check (vk_shift) && (keyboard_check (vk_right) || keyboard_check ("D"))

 

[BladeGamez]

Your second block overwrites your first. If you press right and ****, it turns to spritera, but then immediately gets set back because you arent holding D.

Combine this all into one neat block...

if keyboard_check (vk_shift) && (keyboard_check (vk_right) || keyboard_check ("D"))

This worked to an extent. The sprite will not change to spritera if I hold down D and shift now.

 

[RefresherTowel]

if keyboard_check (vk_shift) && (keyboard_check (vk_right) || keyboard_check ("D")) && keyboard_check (vk_shift)

Will fix that, though, that is such a trivial fix that you should be able to see it by yourself. When you get example code from the forums, make sure to actually read through the code and piece together what it is doing in your head instead of just copy+pasting.

 

[BladeGamez]

if keyboard_check (vk_shift) && (keyboard_check (vk_right) || keyboard_check ("D")) && keyboard_check (vk_shift)

Will fix that, though, that is such a trivial fix that you should be able to see it by yourself. When you get example code from the forums, make sure to actually read through the code and piece together what it is doing in your head instead of just copy+pasting.

Whoops, my bad. I've been up for hours working on this...

 

[RefresherTowel]

I've been there

 

[obscene]

I can't see the mistake no matter how hard I look. Two shift checks shouldn't be necessary if you say...

if shift && ( right || D )

If that's didn't work I'm missing why.

 

[RefresherTowel]

It's saying:

If Shift AND Right are pressed, I will execute the statement
OR if D is pressed, I will execute the statement

So you can see from that statement, it is not checking if Shift AND D are pressed.

 

[obscene]

Nope... the parenthesis are right....



However I just realized I forgot to put ord("D") which I think might be the problem.

So in the end I'm still a loser

 

[RefresherTowel]

Whoops, I didn't notice the parenthesis.

 

[BladeGamez]

Yeah, I noticed that mistake. I had to do a new method anyways because that algorithm did not work when I put a self-created variable in it.