PCG item placement issue(Solved)

[Rizlad]

I wrote a pseudo/test script to test how many surrounding walls there are and if there are the appropriate amount put items in corners and nooks of my generated map, it is putting items almost everywhere. o.o".
Please come to my aid Almighty Programming-Elders!


Floor-tile Script-

///scr_fill_room
poss = 0;

inst = instance_place(x-32,y,obj_cwall);
if inst != noone {
poss++;
}
inst = instance_place(x+32,y,obj_cwall);
if inst != noone {
poss++
}
inst = instance_place(x,y-32,obj_cwall);
if inst != noone {
poss++
}
inst = instance_place(x,y+32,obj_cwall);
if inst != noone {
poss++
}

if (poss >= 3) {
instance_create(x,y,choose(obj_rock,obj_torch));
}
if (poss = 2) {
instance_create(x,y,choose(obj_rock,obj_torch,obj_none,obj_barrel));
}

 

[2Dcube]

What are the sprites/masks of obj_cwall and teh floor tile like? It could be an issue with overlapping where you'd get lots of collisions.

 

[Rizlad]

What are the sprites/masks of obj_cwall and teh floor tile like? It could be an issue with overlapping where you'd get lots of collisions.

Floor tile is not a physics object and wall takes up it's full 32x32 for a mask.

 

[Rizlad]

Floor-tile Script-

///scr_fill_room
poss = 0;

inst = instance_place(x-32,y,obj_cwall);
if inst != noone {
poss++;
}
inst = instance_place(x+32,y,obj_cwall);
if inst != noone {
poss++
}
inst = instance_place(x,y-32,obj_cwall);
if inst != noone {
poss++
}
inst = instance_place(x,y+32,obj_cwall);
if inst != noone {
poss++
}

if (poss >= 3) {
instance_create(x,y,choose(obj_rock,obj_torch));
}
if (poss = 2) {
instance_create(x,y,choose(obj_rock,obj_torch,obj_none,obj_barrel));
}

Fixed my own problem.
as it was running in a script not the object itself had to phase last part as:

if (poss >= 3) {
instance_create(self.x,self.y,choose(obj_rock,obj_torch));
}
if (poss = 2) {
instance_create(self.x,self.y,choose(obj_rock,obj_torch,obj_none,obj_barrel));
}