Issue with button

[Branden Skidmore]

So I'm trying to make a button like how it is in undertale or the older zelda games.
Whenever I run the game in the Compile Errors it says
Object: obj_buttonA Event: Step at line 7 : malformed if statement

My code is below

image_speed = 0

if place_meeting(209,55,Frisk) {
      image_index = 1
}

if (image_index = 0); {
  audio_play_sound(snd_button_press,1,false)

if (image_index = 1) {
     audio_stop_sound(snd_button_press)
     }
}

 

[BattleRifle BR55]

You have a semicolon on the "image_index = 0" line (funny enough, it' the only usage of it in the entire code block and it's in the wrong spot ). I also recommend using two equal signs for comparison, in case compatibility changes in the future.

 

[Andy]

if (image_index = 0);

Remove the ; from this if statement.

EDIT: BR you beat me!

 

[NeonBits]

I don't know if I'm mistaking, as it seems to be possible to check for collision in the same non collision block, but would this run inside an "image_index == 0"?

if (image_index == 1)
{
     audio_stop_sound(snd_button_press);
}

 

[Branden Skidmore]

I don't know if I'm mistaking, as it seems to be possible to check for collision in the same non collision block, but would this run inside an "image_index == 0"?

if (image_index == 1)
{
     audio_stop_sound(snd_button_press);
}

Tbh I don't know because I just found out that image index 0 isn't a thing and I don't know what the first frame of the sprite would be called

 

[NeonBits]

I think (image_index == 0) makes sense... in 1.4, I had to change for 2, which is the third frame, and result is correct.

 

[Taddio]

Tbh I don't know because I just found out that image index 0 isn't a thing and I don't know what the first frame of the sprite would be called

image_index == 0 is definately a thing, it's the first frame of your sprite. Their index start at 0, not 1

 

[Branden Skidmore]

image_index == 0 is definately a thing, it's the first frame of your sprite. Their index start at 0, not 1

I had to change my code up and it still won't detect image_index == 0
It just stops at that bit

 

[Taddio]

Try something like
if(image_index==0){
show_debug_message("Sprite frame = 0");
}
I'm pretty sure it would confirm that it does point to your frame number.
I suspect the problem comes from elsewhere.
Did you removed the semicolons in your if statement, added them after your lines that sets variables and used == instead of = for your comparaisons? (Just to be sure it's not a syntax thing for some reasons)

 

[Branden Skidmore]

Try something like
if(image_index==0){
show_debug_message("Sprite frame = 0");
}
I'm pretty sure it would confirm that it does point to your frame number.
I suspect the problem comes from elsewhere.
Did you removed the semicolons in your if statement, added them after your lines that sets variables and used == instead of = for your comparaisons? (Just to be sure it's not a syntax thing for some reasons)

Idk but here is my new code if it helps explain it

image_speed = 0;

if place_meeting(209,55,Frisk) {
if (image_index == 0)
audio_play_sound(snd_button_press,1,false)
image_index = 1;
 }
}

 

[Taddio]

You're missing a bracket after if(image_index==0)
That's probably it...
...you're also missing a semicolon after audio_play_sound();
That's a no-no!!

You could also just do

if((place_meeting(......)) && (image_index == 0)) {
audio_play_sound(snd_button_press,1,false); //with semicolon
image_index = 1;
}

Edit: there is no need to set your image_speed to 0 every step, just set in in create event and be done with it!

 

[Branden Skidmore]

You're missing a bracket after if(image_index==0)
That's probably it...
...you're also missing a semicolon after audio_play_sound();
That's a no-no!!

You could also just do

if((place_meeting(......)) && (image_index == 0)) {
audio_play_sound(snd_button_press,1,false); //with semicolon
image_index = 1;
}

Edit: there is no need to set your image_speed to 0 every step, just set in in create event and be done with it!

I managed to fix it. But thank you anyway
I could always use that code for other stuff for some diversity!