Game runs extremely slow

[NimNom1234]

Hi.
I'm having a problem in my game. If i spam the attack button, the game slows down to fractions of 1 fps.

Help?

Thanks

 

[TimothyAllen]

Need to see the code. Specifically when your attack button is pressed.

 

[NimNom1234]

instance_create(global.playx, global.playy, obj_char_sword_hitbox)
if global.key_sword = true {
swinging = true
if global.direct = 0 {
sprite_index = spr_char_hitbox_down
alarm[4] = 6.6
}
if global.direct = 1 {
sprite_index = spr_char_hitbox_right
alarm[4] = 6.6
}
if global.direct = 2 {
sprite_index = spr_char_hitbox_up
alarm[4] = 6.6
}
if global.direct = 3 {
sprite_index = spr_char_hitbox_left
alarm[4] = 6.6
}
}
if swinging = false{
instance_destroy()
}



This is the code inside of the swords collision box. key_sword equates to pressing the attack button and swinging is the state of swinging the sword. Lemme know if more is needed

 

[TimothyAllen]

So when is this code ran? Are you creating tons of obj_sword_ hitbox?

 

[NimNom1234]

I didnt think I was, but I might be. The hitbox is created and deleted once every frame. Its being ran in a step event.

 

[TheouAegis]

Where is the code that deletes obj_char_sword_hitbox?

 

[NimNom1234]

if swinging = false {
instance_destroy()
}

At the bottom of the code

 

[TimothyAllen]

Creating that many instance isn't a good idea... even if they only exist for a few frames. That's a lot of memory allocation and GC.

Edit: that will destroy the calling instance... not the hitbox.

 

[NimNom1234]

Where is the code that deletes obj_char_sword_hitbox?

meant to reply earlier :/

 

[NimNom1234]

Creating that many instance isn't a good idea... even if they only exist for a few frames. That's a lot of memory allocation and GC.

How should I edit the code?

 

[TheouAegis]

Don't create hitbox objects. Just change the mask_index for the player, do collision tests for the weapon damage, then reset the mask_index.