Feedback #ifdefined or #ifmacro or any other precompile check [SUGGESTION]

[xDGameStudios]

Hi YoYo team and everyone!
I would like to know if it was possible to add a #ifdefined or #ifmacro precompile check
or another precompile check to check for use within extensions (I'm saying this because I think this is more of an extension development modular feature).

#ifextension extension_name
...
#endif

imagine I have a extension that works differently depending on where there is another extension present or not... for example:

extension A:

#define stuff_manager

extension B:

var stuff = [........];

#ifdefined stuff_manager

stuff_manager_add_new_stuff(stuff);    // this function is from stuff manager

#endif
return stuff;

or would it be a bad ideia to have something like this?!

 

[rwkay]

I am really against doing this as it turns code into spaghetti and is really not a good idea, we already do compile time optimisation so doing something like

#macro ENABLE_STUFF_MANAGER 0

if (ENABLE_STUFF_MANAGER) {
stuff_manager_add_new_stuff( stuff );
}

will already drop the code out completely and it will not be in the compiled output, so I do not see the need to have the macro spaghetti over and above the normal spaghetti of code.

Russell

 

[Tthecreator]

@rwkay well, spaghetti code is a problem on a whole other level, isn't XD
Don't worry I have problems with that too from time to time.

 

[xDGameStudios]

I am really against doing this as it turns code into spaghetti and is really not a good idea, we already do compile time optimisation so doing something like

#macro ENABLE_STUFF_MANAGER 0

if (ENABLE_STUFF_MANAGER) {
stuff_manager_add_new_stuff( stuff );
}

will already drop the code out completely and it will not be in the compiled output, so I do not see the need to have the macro spaghetti over and above the normal spaghetti of code.

Russell

I understand what you mean.. but then we must have an ENABLE_STUFF_MANAGER macro despite having the extension or not... because if not the
if-statement would give an error ENABLE_STUFF_MANAGER doesn't exist!

 

[rwkay]

well you have to have the macro somewhere but you can set it to 1 or 0 depending on if you want the code to run (much like the #if def type thing above)...

never liked the checking for the existence of things before executing code

Russell